Help Idk How...help Me On That Please

[Kelrzher]

1. I want to put if Human , Elf , Dwarf female setGood(true)  and if Orc , delf, male dwarf setEvil(true) i made the code but doesnt work correctly , thinking to delete setevil and change the setGood retail code here:http://pastebin.com/0wdWBjT5
2.  generally i deleted the setevil and changed the setgood to setdestiny i want just to press the button and check if race suits then go to the faction.. Goods : human , elf , female dwarf 

   evil : orc, d.elf , male dwarf

3. package net.sf.l2j;
   	
   	
   	 
   	
   	
   	import java.sql.Connection;
   	
   	
   	import java.sql.PreparedStatement;
   	
   	
   	import java.sql.ResultSet;
   	
   	
   	import java.util.StringTokenizer;
   	
   	
   	import java.util.logging.Logger;
   	
   	
   	 
   	
   	
   	import net.sf.l2j.commons.random.Rnd;
   	
   	
   	import net.sf.l2j.gameserver.ai.CtrlIntention;
   	
   	
   	import net.sf.l2j.gameserver.model.L2World;
   	
   	
   	import net.sf.l2j.gameserver.model.actor.instance.L2NpcInstance;
   	
   	
   	import net.sf.l2j.gameserver.model.actor.instance.L2PcInstance;
   	
   	
   	import net.sf.l2j.gameserver.model.actor.template.NpcTemplate;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.ActionFailed;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.MyTargetSelected;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.NpcHtmlMessage;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.SocialAction;
   	
   	
   	import net.sf.l2j.gameserver.network.serverpackets.ValidateLocation;
   	
   	
   	 
   	
   	
   	 
   	
   	
   	 
   	
   	
   	public class L2FactionInstance extends L2NpcInstance
   	
   	
   	{
   	
   	
   	 
   	
   	
   	    public L2FactionInstance(int objectId, NpcTemplate template)
   	
   	
   	    {
   	
   	
   	        super(objectId, template);
   	
   	
   	    }
   	
   	
   	 
   	
   	
   	    private final static Logger _log = Logger.getLogger(L2FactionInstance.class.getName());
   	
   	
   	 
   	
   	
   	    @Override
   	
   	
   	    public void onBypassFeedback(L2PcInstance player, String command)
   	
   	
   	    {
   	
   	
   	        player.sendPacket(ActionFailed.STATIC_PACKET);
   	
   	
   	        StringTokenizer st = new StringTokenizer(command, " ");
   	
   	
   	        String actualCommand = st.nextToken();
   	
   	
   	        @SuppressWarnings("unused")
   	
   	
   	        String val = "";
   	
   	
   	        if (st.countTokens() >= 1)
   	
   	
   	        {
   	
   	
   	            val = st.nextToken();
   	
   	
   	    }
   	
   	
   	 
   	
   	
   	        else if (actualCommand.equalsIgnoreCase("setdestiny"))
   	
   	
   	        {
   	
   	
   	           
   	
   	
   	        setTarget(player);
   	
   	
   	       
   	
   	
   	            if (player.isGood())
   	
   	
   	            {
   	
   	
   	                player.sendMessage("You already are in " + Config.FACTION_NAME_TEAM_GOOD + " faction ");
   	
   	
   	                player.sendPacket(new ActionFailed());
   	
   	
   	            }
   	
   	
   	           if(player.getRace blabla bla 
   	
   	
   	                    {
   	
   	
   	                    player.setGood(true);
   	
   	
   	                    Connection connection = null;
   	
   	
   	                        try
   	
   	
   	                        {
   	
   	
   	                            connection = L2DatabaseFactory.getInstance().getConnection();
   	
   	
   	                            PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");
   	
   	
   	                            statement.setString(1, player.getName());
   	
   	
   	                            ResultSet rset = statement.executeQuery();
   	
   	
   	                            int objId = 0;
   	
   	
   	                        if (rset.next())
   	
   	
   	                            {
   	
   	
   	                                objId = rset.getInt(1);
   	
   	
   	                            }
   	
   	
   	                            rset.close();
   	
   	
   	                            statement.close();
   	
   	
   	                            if (objId == 0)
   	
   	
   	                            {
   	
   	
   	                                connection.close();
   	
   	
   	                                return;
   	
   	
   	                            }
   	
   	
   	                            statement = connection.prepareStatement("UPDATE characters SET good=1 WHERE obj_Id=?");
   	
   	
   	                        statement.setInt(1, objId);
   	
   	
   	                            statement.execute();
   	
   	
   	                            statement.close();
   	
   	
   	                            connection.close();
   	
   	
   	                        }
   	
   	
   	                        catch (Exception e)
   	
   	
   	                        {
   	
   	
   	                            _log.info("could not set good status of char:");
   	
   	
   	                        }
   	
   	
   	                        finally
   	
   	
   	                        {
   	
   	
   	                            try
   	
   	
   	                            {
   	
   	
   	                                connection.close();
   	
   	
   	                            }
   	
   	
   	                            catch (Exception e)
   	
   	
   	                            {
   	
   	
   	                            }
   	
   	
   	                        }
   	
   	
   	                   
   	
   	
   	                        if (player.isGood())
   	
   	
   	                        {
   	
   	
   	                            player.broadcastUserInfo();
   	
   	
   	                            player.sendMessage("You Are fighiting Now for" + Config.FACTION_NAME_TEAM_GOOD + " Faction ");
   	
   	
   	                            player.getAppearance().setNameColor(Config.FACTION_COLOR_NAME_GOOD);
   	
   	
   	                            player.teleToLocation(Config.GOODX, Config.GOODY, Config.GOODZ);
   	
   	
   	                            player.setTitle(Config.FACTION_NAME_TEAM_GOOD);
   	
   	
   	                        }
   	
   	
   	                    }
   	
   	
   	                }
   	
   	
   	        }
   	
   	
   	        }
   	
   	
   	           
   	
   	
   	                    else if(player.getRace() == Race.Orc() bla bla bla
   	
   	
   	                    {
   	
   	
   	                        player.setEvil(true);
   	
   	
   	                        Connection connection = null;
   	
   	
   	                        try
   	
   	
   	                        {
   	
   	
   	                            connection = L2DatabaseFactory.getInstance().getConnection();
   	
   	
   	                            PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");
   	
   	
   	                            statement.setString(1, player.getName());
   	
   	
   	                            ResultSet rset = statement.executeQuery();
   	
   	
   	                            int objId = 0;
   	
   	
   	                            if (rset.next())
   	
   	
   	                        {
   	
   	
   	                                objId = rset.getInt(1);
   	
   	
   	                        }
   	
   	
   	                            rset.close();
   	
   	
   	                            statement.close();
   	
   	
   	                            if (objId == 0)
   	
   	
   	                            {
   	
   	
   	                                connection.close();
   	
   	
   	                                return;
   	
   	
   	                            }
   	
   	
   	                            statement = connection.prepareStatement("UPDATE characters SET evil=1 WHERE obj_Id=?");
   	
   	
   	                            statement.setInt(1, objId);
   	
   	
   	                            statement.execute();
   	
   	
   	                            statement.close();
   	
   	
   	                            connection.close();
   	
   	
   	                        }
   	
   	
   	                        catch (Exception e)
   	
   	
   	                        {
   	
   	
   	                            _log.info("could not set evil status of char:");
   	
   	
   	                        }
   	
   	
   	                        finally
   	
   	
   	                        {
   	
   	
   	                            try
   	
   	
   	                            {
   	
   	
   	                                connection.close();
   	
   	
   	                            }
   	
   	
   	                            catch (Exception e)
   	
   	
   	                            {
   	
   	
   	                            }
   	
   	
   	                        }
   	
   	
   	                   
   	
   	
   	                        if (player.isEvil())
   	
   	
   	                        {
   	
   	
   	                            player.broadcastUserInfo();
   	
   	
   	                            player.sendMessage("You Are fighiting Now for " + Config.FACTION_NAME_TEAM_EVIL + " Faction ");
   	
   	
   	                            player.getAppearance().setNameColor(Config.FACTION_COLOR_NAME_EVIL);
   	
   	
   	                            player.teleToLocation(Config.EVILX, Config.EVILY, Config.EVILZ);
   	
   	
   	                            player.setTitle(Config.FACTION_NAME_TEAM_EVIL);
   	
   	
   	                        }
   	
   	
   	                    }
   	
   	
   	                }
   	
   	
   	            
   	
   	
   	        else if (actualCommand.equalsIgnoreCase("setnobless"))
   	
   	
   	        {
   	
   	
   	       
   	
   	
   	            L2PcInstance activeChar = player;
   	
   	
   	            if (activeChar.isNoble())
   	
   	
   	                activeChar.sendMessage("You Are Already A Noblesse!.");
   	
   	
   	            else
   	
   	
   	            {
   	
   	
   	                activeChar.setNoble(true, true);
   	
   	
   	                activeChar.sendMessage("You Are Now a Noble,You Are Granted With Noblesse Status , And Noblesse Skills.");
   	
   	
   	                activeChar.broadcastUserInfo();
   	
   	
   	                activeChar.getInventory().addItem("Tiara", 7694, 1, activeChar, null);
   	
   	
   	            }
   	
   	
   	        }
   	
   	
   	        else
   	
   	
   	        {
   	
   	
   	            super.onBypassFeedback(player, command);
   	
   	
   	        }
   	
   	
   	    }
   	
   	
   	   
   	
   	
   	    @Override
   	
   	
   	    public String getHtmlPath(int npcId, int val)
   	
   	
   	    {
   	
   	
   	        return "data/html/mods/faction/main.htm";
   	
   	
   	    }
   	
   	
   	 
   	
   	
   	}

Edited December 7, 2016 by Kelrzher

[Tryskell]

You can simply override the Race enum or whatever you use. On aCis it's now named ClassRace, and breath multiplier is already applied to give you an idea of how you should do it.

 

https://xp-dev.com/svn/aCis_public/aCis_gameserver/java/net/sf/l2j/gameserver/model/base/Race.java

 

That way you simply 

player.getRace().getFaction()

About how to store faction, try to keep it as an enum. And don't use setEvil / setGood, it's soooooo 2008 writting style.

Edited December 7, 2016 by Tryskell

[Kelrzher]

You can simply override the Race enum or whatever you use. On aCis it's now named ClassRace, and breath multiplier is already applied to give you an idea of how you should do it.

 

https://xp-dev.com/svn/aCis_public/aCis_gameserver/java/net/sf/l2j/gameserver/model/base/Race.java

 

That way you simply 

player.getRace().getFaction()

About how to store faction, try to keep it as an enum. And don't use setEvil / setGood, it's soooooo 2008 writting style.

i made it through pc instance but i am sure its totally wrong .. well 2008 styling makes me happy for now hahah :D check , so bad but maybe will work?

 

//faction start

public boolean isGood()

{

if (getRace() == Race.Dwarf && getAppearance().getSex() && getRace() == Race.Elf && getRace() == Race.Human)

{

setGood(true);

}

 

         Connection connection = null;

             try

             {

                 connection = L2DatabaseFactory.getInstance().getConnection();

                 PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");

                 statement.setString(1, getName());

                 ResultSet rset = statement.executeQuery();

                 int objId = 0;

             if (rset.next())

                 {

                     objId = rset.getInt(1);

                 }

                 rset.close();

                 statement.close();

                 if (objId == 0)

                 {

                     connection.close();

                     return false;

                 }

                 statement = connection.prepareStatement("UPDATE characters SET good=1 WHERE obj_Id=?");

             statement.setInt(1, objId);

                 statement.execute();

                 statement.close();

                 connection.close();

             }

             catch (Exception e)

             {

                 _log.info("could not set good status of char:");

             }

             finally

             {

                 try

                 {

                     connection.close();

                 }

                 catch (Exception e)

                 {

                 }

             }

return _isGood;

}

        

public boolean isEvil()

{

if (getRace() == Race.Dwarf && !getAppearance().getSex() && getRace() == Race.DarkElf && getRace() == Race.Orc)

{

setEvil(true);

}

         Connection connection = null;

         try

         {

             connection = L2DatabaseFactory.getInstance().getConnection();

             PreparedStatement statement = connection.prepareStatement("SELECT obj_Id FROM characters where char_name=?");

             statement.setString(1, getName());

             ResultSet rset = statement.executeQuery();

             int objId = 0;

             if (rset.next())

         {

                 objId = rset.getInt(1);

         }

             rset.close();

             statement.close();

             if (objId == 0)

             {

                 connection.close();

                 return false;

             }

             statement = connection.prepareStatement("UPDATE characters SET evil=1 WHERE obj_Id=?");

             statement.setInt(1, objId);

             statement.execute();

             statement.close();

             connection.close();

         }

         catch (Exception e)

         {

             _log.info("could not set evil status of char:");

         }

         finally

         {

             try

             {

                 connection.close();

             }

             catch (Exception e)

             {

             }

         }

return _isEvil;

}

      

public void setGood(boolean value)

{

   _isGood = value;

}

      

public void setEvil(boolean value)

{

   _isEvil = value;

}

Edited December 7, 2016 by Kelrzher

[Sdw]

Beside the bed coding style, it's full of typo and failed logic, it won't work

Edited December 7, 2016 by Sdw

[xxdem]

You can simply override the Race enum or whatever you use. On aCis it's now named ClassRace, and breath multiplier is already applied to give you an idea of how you should do it.

 

https://xp-dev.com/svn/aCis_public/aCis_gameserver/java/net/sf/l2j/gameserver/model/base/Race.java

 

That way you simply 

player.getRace().getFaction()

About how to store faction, try to keep it as an enum. And don't use setEvil / setGood, it's soooooo 2008 writting style.

 

You know that "override enum" is a completely wrong sentence right? Enums can never be extended or have children/parent/friends in Java

 

The answer is, edit Race enum, not override it

[Kelrzher]

i tottaly killed it , i moved the code to the onplayerenter for now to test,,

[Reborn12]

Edit:

If player get race this set good..

Player.teletolocation blabla

Else if player get race this setevil

Player teletolocation blabla

On charactercreate maybe will be fine..just my idea

Edited December 7, 2016 by Reborn12

[Tryskell]

If it's a race based faction type and you can't manually edit faction, it's pointless to store it on database. What I told you is far enough.

 

The code you use, I know it well, since it's the first custom I added when I was deving on l2j archid in 2009.

 

@xxdem ty captain obvious. Keep trolling.

Edited December 7, 2016 by Tryskell

[Kelrzher]

If it's a race based faction type and you can't manually edit faction, it's pointless to store it on database. What I told you is far enough.

 

The code you use, I know it well, since it's the first custom I added when I was deving on l2j archid in 2009.

 

@xxdem ty captain obvious. Keep trolling.

how the heck i will write the code on race.java looool 

[Tryskell]

how the heck i will write the code on race.java looool 

 

The same way I added breath multiplier. Did you read my initial answer, or no ?

[Kelrzher]

sendPacket(CharCreateOk.STATIC_PACKET);

L2World.getInstance().addObject(newChar);

if (newChar.getRace() == Race.Dwarf &&   newChar.getRace() == Race.Elf && newChar.getRace() == Race.Human)

{

newChar.setGood(true);

newChar.sendMessage("Litourgo");

}

 

if (newChar.getRace() == Race.DarkElf && newChar.getRace() == Race.Orc)

{

newChar.setEvil(true);

newChar.sendMessage("Ime evil");

} on charcreate file ot work

[Kelrzher]

The same way I added breath multiplier. Did you read my initial answer, or no ?

yes i try that now

[Tessa]

public enum Faction {
    GOOD,
    EVIL;
}

public final class L2PcInstance extends L2Playable
{
    // ...

    private Faction faction;

    // ...

    public Faction getFaction() {
        return this.faction;
    }

    public void setFaction(Faction faction) {
        this.faction = faction;
    }

    public boolean isGood() {
        return this.faction == Faction.GOOD;
    }

public class EnterWorld extends L2GameClientPacket
{
    // ...
    @Override
    protected void runImpl()
    {
        // ...
        if (activeChar.getRace() == Race.Human || activeChar.getRace() == Race.Elf || (activeChar.getRace() == Race.Dwarf && activeChar.getAppearance().getSex())) {
            activeChar.setFaction(Faction.GOOD);
        } else {
            activeChar.setFaction(Faction.EVIL);
        }

:lol:

Edited December 8, 2016 by Tessa

[AccessDenied]

public enum Faction {
    GOOD,
    EVIL;
}

public final class L2PcInstance extends L2Playable
{
    // ...

    private Faction faction;

    // ...

    public Faction getFaction() {
        return this.faction;
    }

    public void setFaction(Faction faction) {
        this.faction = faction;
    }

    public boolean isGood() {
        if (faction == Faction.GOOD) {
            return true;
        }

        return false;
    }

public class EnterWorld extends L2GameClientPacket
{
    // ...
    @Override
    protected void runImpl()
    {
        // ...
        if (activeChar.getRace() == Race.Human || activeChar.getRace() == Race.Elf || (activeChar.getRace() == Race.Dwarf && activeChar.getAppearance().getSex())) {
            activeChar.setFaction(Faction.GOOD);
        } else {
            activeChar.setFaction(Faction.EVIL);
        }

:lol:

 

:O did you just extend L2GameClientPacket ????? :o

[Kelrzher]

my mind became chorcoal... idk... i deleted everything rofl

[Tessa]

:o did you just extend L2GameClientPacket ????? :o

No, this is the latest aCis free version :lol: