Darule Posted July 23, 2012 Author Share Posted July 23, 2012 dude one suggestion, you should change something in TopPlayer.java, String adenas = getAdenas(result.getInt("SUM(it.count)")); to this String adenas = getAdenas(result.getLong("SUM(it.count)")); and make this: public String getAdenas(long adena) { String adenas = ""; if (adena >= 1000000000) adenas = Long.toString(adena / 1000000000) + " Billion " + Long.toString((adena % 1000000000) / 1000000) + " million"; else adenas = Long.toString(adena / 1000000) + " Million " + Long.toString((adena % 1000000) / 1000) + " k"; return adenas; } btw nice work!! Yes thats correct i've only test this local so i missed this one ;) , thanks. Link to comment Share on other sites More sharing options...
valanths1990 Posted July 23, 2012 Share Posted July 23, 2012 for top lists you should create a threadpool manager, to reload top lists every 30 mins for example, so players want access database directly ;) Link to comment Share on other sites More sharing options...
marcose Posted July 23, 2012 Share Posted July 23, 2012 marcose if u dont like it dont spam here becouse this is verry good and functional CB and most ppl's verry like that share Your english is "verry" good Link to comment Share on other sites More sharing options...
Darule Posted July 23, 2012 Author Share Posted July 23, 2012 Your english is "verry" good Dude stop spamming in my topic, thanks. Link to comment Share on other sites More sharing options...
kadabra Posted July 23, 2012 Share Posted July 23, 2012 Thanks Darule! Link to comment Share on other sites More sharing options...
NAM Posted July 23, 2012 Share Posted July 23, 2012 Very Good !! thanks. Link to comment Share on other sites More sharing options...
NAM Posted July 23, 2012 Share Posted July 23, 2012 Very Good !! thanks. Link to comment Share on other sites More sharing options...
vampir Posted July 23, 2012 Share Posted July 23, 2012 Very nice coded, but i have got few advices [PL] -na koncu kwerend nie musisz dawac ";" :P -klasa GrandBossList jest nie potrzebna bo podobna klasa juz istnieje w l2jserver, popatrz na RaidBossSpawnManager -result.close() i statement.close() ZAWSZE dawaj do finally, bo jesli cos pojdzie nie tak, polaczenie sie nie zamknie [/PL] thx for sharing it :) Link to comment Share on other sites More sharing options...
Darule Posted July 23, 2012 Author Share Posted July 23, 2012 Very nice coded, but i have got few advices [PL] -na koncu kwerend nie musisz dawac ";" :P -klasa GrandBossList jest nie potrzebna bo podobna klasa juz istnieje w l2jserver, popatrz na RaidBossSpawnManager -result.close() i statement.close() ZAWSZE dawaj do finally, bo jesli cos pojdzie nie tak, polaczenie sie nie zamknie [/PL] thx for sharing it :) Thanks, but why did you told the advices in PL im not from Poland, but thanks anyway for your advices some1 might use them and make a better cb but i dont think that im going to update it anytime soon, this was made for personal use and anyone is free to mod it in any way they want for their needs. Btw about the RaidBossSpawnManager i dont remember how it worked or if i could use it, but an extra class is not such a big deal since its more organized i think to have them all in one place, since the RbSpawnManager can change anytime from l2jserver. Link to comment Share on other sites More sharing options...
vampir Posted July 23, 2012 Share Posted July 23, 2012 Thanks, but why did you told the advices in PL im not from Poland, but thanks anyway for your advices some1 might use them and make a better cb but i dont think that im going to update it anytime soon, this was made for personal use and anyone is free to mod it in any way they want for their needs. Btw about the RaidBossSpawnManager i dont remember how it worked or if i could use it, but an extra class is not such a big deal since its more organized i think to have them all in one place, since the RbSpawnManager can change anytime from l2jserver. sorry, i thought u are from poland. I wrote those advises to try avoid such things in future, not to update community. I dont really like your RaidBoss class coz everytime somebody is clicking in community to check raid boss respawn(and lets say that will be often), also database will be used more often coz of that which isnt very healthy :) Link to comment Share on other sites More sharing options...
Darule Posted July 23, 2012 Author Share Posted July 23, 2012 sorry, i thought u are from poland. I wrote those advises to try avoid such things in future, not to update community. I dont really like your RaidBoss class coz everytime somebody is clicking in community to check raid boss respawn(and lets say that will be often), also database will be used more often coz of that which isnt very healthy :) Well thats not quite true, i mean it doesnt check the db everytime cause there is the cache too. In short when for example 10 users browse this pages and an 11th user come and click it, it wont access the db but it will send him the cached html and it will be refreshed again after some time like 5 mins im not sure how the htm cache works or how its done but its not accessed everytime. Link to comment Share on other sites More sharing options...
vampir Posted July 23, 2012 Share Posted July 23, 2012 Well thats not quite true, i mean it doesnt check the db everytime cause there is the cache too. In short when for example 10 users browse this pages and an 11th user come and click it, it wont access the db but it will send him the cached html and it will be refreshed again after some time like 5 mins im not sure how the htm cache works or how its done but its not accessed everytime. oh, i am sorry then, didnt know about that. Link to comment Share on other sites More sharing options...
dymek1984 Posted July 23, 2012 Share Posted July 23, 2012 Formestill not working. what i need to have in config? like i say compilation was goodbuthave error in game 404 filrnotfounf "index.htm" i checked and files is in communityboard folder. Link to comment Share on other sites More sharing options...
SweeTs Posted July 24, 2012 Share Posted July 24, 2012 Formestill not working. what i need to have in config? like i say compilation was goodbuthave error in game 404 filrnotfounf "index.htm" i checked and files is in communityboard folder. Jeez, you should read replies more carefully. [PL] Jak mówi error, brakuje Ci głównego pliku index.htm - dlatego Ci nic nie wyświetla bo nie ma co. Więc dodaj ten plik do data\html\CommunityBoard [/PL] To be more specific, download Datapack part and paste all htm files into CommunityBoard folder.. Link to comment Share on other sites More sharing options...
`NeverMore Posted July 28, 2012 Share Posted July 28, 2012 it is shared many times but this is the best one ! Awesome work and awesome code ! + 1 reputation from me , for your 1500 lines code + many html files ! Keep Sharing m8 !!! Link to comment Share on other sites More sharing options...
Recommended Posts